chore: remove beta tag from SQL insight insightNavLogic.tsx #23757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data Warehouse is out of beta, so it's a little confusing to have the beta tag in (one of) the main access point(s).
📸 UI snapshots have been updated93 snapshot changes in total. 0 added, 93 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
EDsCODE
approved these changes
Jul 16, 2024
EDsCODE
changed the title
|
Flagging for visibility: There is one breaking thing that may need to change with HogQL: array indexes. More details here: https://github.com/PostHog/product-internal/pull/623/files A "beta" tag gives us some cover here, but it likely won't make any real difference to the task at hand. |
silentninja
pushed a commit
to silentninja/posthog
that referenced
this pull request
Aug 8, 2024
…23757) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Eric Duong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Data Warehouse is out of beta, so it's a little confusing to have the beta tag in (one of) the main access point(s). If there's a compelling reason to keep this, feel free to disregard (PR > Issues)
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?